-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[cdc-base] Close idle readers when snapshot finished #2162
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
57 changes: 57 additions & 0 deletions
57
flink-cdc-base/src/main/java/com/ververica/cdc/connectors/base/utils/EnvironmentUtils.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,57 @@ | ||
| /* | ||
| * Copyright 2022 Ververica Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.ververica.cdc.connectors.base.utils; | ||
|
|
||
| import org.apache.flink.configuration.Configuration; | ||
| import org.apache.flink.runtime.util.EnvironmentInformation; | ||
|
|
||
| /** Utilities for environment information at runtime. */ | ||
| public class EnvironmentUtils { | ||
|
|
||
| private EnvironmentUtils() {} | ||
|
|
||
| private static final VersionComparable FLINK_1_14 = VersionComparable.fromVersionString("1.14"); | ||
|
|
||
| private static final String ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH = | ||
| "execution.checkpointing.checkpoints-after-tasks-finish.enabled"; | ||
|
|
||
| public static VersionComparable runtimeFlinkVersion() { | ||
| return VersionComparable.fromVersionString(EnvironmentInformation.getVersion()); | ||
| } | ||
|
|
||
| public static void requireCheckpointsAfterTasksFinished(Configuration configuration) { | ||
| if (!supportCheckpointsAfterTasksFinished()) { | ||
| throw new UnsupportedOperationException( | ||
| "To enabled checkpoints after tasks finished requires flink version greater than or equal to 1.14, current version is " | ||
| + runtimeFlinkVersion()); | ||
| } | ||
| if (!enableCheckPointsAfterTaskFinishes(configuration)) { | ||
| throw new IllegalArgumentException( | ||
| String.format( | ||
| "To enabled checkpoints after tasks finished requires '%s' set to true.", | ||
| ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH)); | ||
| } | ||
| } | ||
|
|
||
| public static boolean supportCheckpointsAfterTasksFinished() { | ||
| return runtimeFlinkVersion().newerThanOrEqualTo(FLINK_1_14); | ||
| } | ||
|
|
||
| public static boolean enableCheckPointsAfterTaskFinishes(Configuration configuration) { | ||
| return configuration.getBoolean(ENABLE_CHECKPOINTS_AFTER_TASKS_FINISH, false); | ||
| } | ||
| } |
107 changes: 107 additions & 0 deletions
107
flink-cdc-base/src/main/java/com/ververica/cdc/connectors/base/utils/VersionComparable.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,107 @@ | ||
| /* | ||
| * Copyright 2022 Ververica Inc. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.ververica.cdc.connectors.base.utils; | ||
|
|
||
| /** Used to compare version numbers at runtime. */ | ||
| public class VersionComparable implements Comparable<VersionComparable> { | ||
|
|
||
| private int majorVersion; | ||
| private int minorVersion; | ||
| private int patchVersion; | ||
| private String versionString; | ||
|
|
||
| public VersionComparable(String versionString) { | ||
| this.versionString = versionString; | ||
| try { | ||
| int pos = versionString.indexOf('-'); | ||
| String numberPart = versionString; | ||
| if (pos > 0) { | ||
| numberPart = versionString.substring(0, pos); | ||
| } | ||
|
|
||
| String[] versions = numberPart.split("\\."); | ||
|
|
||
| this.majorVersion = Integer.parseInt(versions[0]); | ||
| this.minorVersion = Integer.parseInt(versions[1]); | ||
| if (versions.length == 3) { | ||
| this.patchVersion = Integer.parseInt(versions[2]); | ||
| } | ||
| } catch (Exception e) { | ||
| throw new IllegalArgumentException( | ||
| String.format("Can not recognize version %s.", versionString)); | ||
| } | ||
| } | ||
|
|
||
| public int getMajorVersion() { | ||
| return majorVersion; | ||
| } | ||
|
|
||
| public int getMinorVersion() { | ||
| return minorVersion; | ||
| } | ||
|
|
||
| public int getPatchVersion() { | ||
| return patchVersion; | ||
| } | ||
|
|
||
| public static VersionComparable fromVersionString(String versionString) { | ||
| return new VersionComparable(versionString); | ||
| } | ||
|
|
||
| @Override | ||
| public int compareTo(VersionComparable version) { | ||
| if (equalTo(version)) { | ||
| return 0; | ||
| } else if (newerThan(version)) { | ||
| return 1; | ||
| } else { | ||
| return -1; | ||
| } | ||
| } | ||
|
|
||
| public boolean equalTo(VersionComparable version) { | ||
| return majorVersion == version.majorVersion | ||
| && minorVersion == version.minorVersion | ||
| && patchVersion == version.patchVersion; | ||
| } | ||
|
|
||
| public boolean newerThan(VersionComparable version) { | ||
| if (majorVersion <= version.majorVersion) { | ||
| if (majorVersion < version.majorVersion) { | ||
| return false; | ||
| } else { | ||
| if (minorVersion <= version.minorVersion) { | ||
| if (minorVersion < version.patchVersion) { | ||
| return false; | ||
| } else { | ||
| return patchVersion > version.patchVersion; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| return true; | ||
| } | ||
|
|
||
| public boolean newerThanOrEqualTo(VersionComparable version) { | ||
| return newerThan(version) || equalTo(version); | ||
| } | ||
|
|
||
| @Override | ||
| public String toString() { | ||
| return versionString; | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this option's default value should be
true, for the old flink version which don't support should be settedfalseby user.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Jiabao-Sun As you said , flink disabled by default. So ignore this comment. :)