Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[doc] Add docs for close idle readers feature. #2208

Merged
merged 3 commits into from
Jun 13, 2023

Conversation

Jiabao-Sun
Copy link
Contributor

Add docs for close idle readers feature.

<td>optional</td>
<td style="word-wrap: break-word;">false</td>
<td>Boolean</td>
<td>是否在快照结束后关闭空闲的Reader. 此特性需要 flink 版本大于等于 1.14 并且 'execution.checkpointing.checkpoints-after-tasks-finish.enabled' 需要设置为 true.</td>
Copy link
Member

@GOODBOY008 GOODBOY008 Jun 13, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use instead of . and add spaces between Chinese and English.

<td>optional</td>
<td style="word-wrap: break-word;">false</td>
<td>Boolean</td>
<td>是否在快照结束后关闭空闲的Reader. 此特性需要 flink 版本大于等于 1.14 并且 'execution.checkpointing.checkpoints-after-tasks-finish.enabled' 需要设置为 true.</td>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Jiabao-Sun I have left some comments. Thanks for your contributions.

Copy link
Member

@GOODBOY008 GOODBOY008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GOODBOY008 GOODBOY008 merged commit be9e657 into apache:master Jun 13, 2023
spoon-lz pushed a commit to spoon-lz/flink-cdc-connectors that referenced this pull request Jun 13, 2023
* [doc] Add docs for close idle readers feature
@Jiabao-Sun Jiabao-Sun deleted the FLINK-CDC-1731-DOC branch December 6, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants