Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flink-connector-mysql-cdc] fix snapshot read thread exit due to erro… #2362

Merged

Conversation

TJX2014
Copy link
Contributor

@TJX2014 TJX2014 commented Aug 2, 2023

Currently when OutOfMemoryError or other Error not Exception caused in fetcher thread, outside will not know it but the fetcher thread is exit; So this patch change the Exception catch to Throwable which will catch OutOfMemoryError and something else.

@TJX2014
Copy link
Contributor Author

TJX2014 commented Aug 13, 2023

cc @ruanhang1993 @leonardBang

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @TJX2014 for the contribution, LGTM

@leonardBang leonardBang merged commit 094fff4 into apache:master Aug 14, 2023
13 of 15 checks passed
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
This closes #apache#2362.
Co-authored-by: TJX2014 <[email protected]>

(cherry picked from commit 094fff4)
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
This closes #apache#2362.
Co-authored-by: TJX2014 <[email protected]>

(cherry picked from commit 094fff4)
GOODBOY008 pushed a commit to GOODBOY008/flink-cdc that referenced this pull request Oct 30, 2023
This closes #apache#2362.
Co-authored-by: TJX2014 <[email protected]>

(cherry picked from commit 094fff4)
leonardBang pushed a commit that referenced this pull request Oct 31, 2023
This closes ##2362.
Co-authored-by: TJX2014 <[email protected]>

(cherry picked from commit 094fff4)
zhongqishang pushed a commit to zhongqishang/flink-cdc that referenced this pull request Dec 7, 2023
This closes #apache#2362.
Co-authored-by: TJX2014 <[email protected]>

(cherry picked from commit 094fff4)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants