-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[postgres] never drop slot for stream split, which is also global split #2436
Merged
ruanhang1993
merged 4 commits into
apache:master
from
loserwang1024:test_slot.drop.on.stop
Sep 26, 2023
Merged
[postgres] never drop slot for stream split, which is also global split #2436
ruanhang1993
merged 4 commits into
apache:master
from
loserwang1024:test_slot.drop.on.stop
Sep 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
….drop.on.stop = true (apache#2431)
loserwang1024
changed the title
Test slot.drop.on.stop
[postgres] never drop slot for stream split, which is also global split
Aug 29, 2023
loserwang1024
force-pushed
the
test_slot.drop.on.stop
branch
from
August 29, 2023 07:18
11b571b
to
9f52050
Compare
@TyrantLucifer , CC. |
ruanhang1993
reviewed
Sep 7, 2023
.../src/main/java/com/ververica/cdc/connectors/postgres/source/fetch/PostgresScanFetchTask.java
Show resolved
Hide resolved
loserwang1024
force-pushed
the
test_slot.drop.on.stop
branch
from
September 13, 2023 09:04
b0f6839
to
7a52746
Compare
ruanhang1993
approved these changes
Sep 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
e-mhui
pushed a commit
to e-mhui/flink-cdc-connectors
that referenced
this pull request
Oct 18, 2023
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit 928ccf1)
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit 928ccf1)
GOODBOY008
pushed a commit
to GOODBOY008/flink-cdc
that referenced
this pull request
Oct 30, 2023
(cherry picked from commit 928ccf1)
leonardBang
pushed a commit
that referenced
this pull request
Oct 31, 2023
(cherry picked from commit 928ccf1)
zhongqishang
pushed a commit
to zhongqishang/flink-cdc
that referenced
this pull request
Dec 7, 2023
(cherry picked from commit 928ccf1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #2431