Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[test] Introduce JUnit 5 and AssertJ dependencies #2659

Merged
merged 3 commits into from
Nov 8, 2023

Conversation

PatrickRen
Copy link
Contributor

This pull request implement #2657, which introduces JUnit 5 and AssertJ dependencies in the root pom, including:

  • Use junit-bom in dependency management to pin JUnit 5 versions for all modules
  • Introduce AssertJ as global test dependency
  • Bump maven-surefire-plugin version to 3.0.0-M5, which has better support for JUnit 5

@PatrickRen
Copy link
Contributor Author

Actually the project is already using JUnit 5 (see the import here), which is a transitive dependency of Flink test utils. This pull request makes the dependency clearer and under managed.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @PatrickRen for the contribution, LGTM

@leonardBang leonardBang merged commit 80603a6 into apache:master Nov 8, 2023
14 checks passed
@leonardBang leonardBang added this to the V3.0.0 milestone Nov 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants