[cdc-connector][sqlserver][tests] Fix UT errors by correcting right output #2864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loserwang1024
force-pushed
the
fix-sqlserver-test
branch
from
5d4ff4d
to
c190b49
Compare
loserwang1024
force-pushed
the
fix-sqlserver-test
branch
from
c190b49
to
79bf604
Compare
|
@gong @leonardBang @GOODBOY008 , CC, before we fix #2853, fix the CI not to block other PR. |
|
@leonardBang , @GOODBOY008 , CC |
|
Thanks @loserwang1024 and @gong for the contribution, LGTM. Let's track this issue in #2853 |
joyCurry30
pushed a commit
to joyCurry30/flink-cdc-connectors
that referenced
this pull request
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in #2853, SqlServer incremental source cannot support exactly-once now.
Between the time that a change is committed in the source table, and the time that the change appears in the corresponding change table, there is always a small latency interval.
Because the time is random, the test com.ververica.cdc.connectors.sqlserver.source.SqlServerSourceITCase#testEnableBackfillWithDMLPreHighWaterMark will sometime fail even sleep for 5 minute.
however, it's rather than tricky, may not be fixed recently. In oder to not influence other PR's CI , before #2853 is fixed, fix UT errors by correcting right output which includes duplicate data.