Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cdc-connector][sqlserver] sqlserver support use specific chunk column as a split key #2972

Merged
merged 2 commits into from
Jan 25, 2024

Conversation

gong
Copy link
Contributor

@gong gong commented Jan 6, 2024

Prepare a Pull Request

Motivation

sqlserver support use specific chunk column as a split key

Modifications

  • Modify SqlServerUtils#getSplitColumn by adding a chunkKeyColumn param
  • Add doc about chunk column
  • Add ITcase UT about using chunk coulmn

@github-actions github-actions bot added docs Improvements or additions to documentation sqlserver-cdc-connector labels Jan 6, 2024
@gong
Copy link
Contributor Author

gong commented Jan 6, 2024

@leonardBang @GOODBOY008 PTAL

@gong
Copy link
Contributor Author

gong commented Jan 6, 2024

@lvyanquan Hello, please help me to address UT fail about ValuesDataSourceITCase#testMultiSplitsSingleTable. I can't reproduce this UT error locally. This UT of the module is also not related to my modifications.

@gong gong force-pushed the feature-sqlserver-chunkcolumn branch from 878bba0 to 6409d27 Compare January 10, 2024 14:49
@gong
Copy link
Contributor Author

gong commented Jan 20, 2024

@lvyanquan PTAL

Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gong for the update, LGTM

@leonardBang leonardBang merged commit 10e542c into apache:master Jan 25, 2024
15 of 17 checks passed
joyCurry30 pushed a commit to joyCurry30/flink-cdc-connectors that referenced this pull request Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cdc-connector][sqlserver] sqlserver support use specific chunk column as a split key
3 participants