Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cdc-connector][oracle] oracle support use specific chunk column as a split key #2976

Merged
merged 3 commits into from
Jan 24, 2024
Merged

[cdc-connector][oracle] oracle support use specific chunk column as a split key #2976

merged 3 commits into from
Jan 24, 2024

Conversation

gong
Copy link
Contributor

@gong gong commented Jan 7, 2024

Prepare a Pull Request

Motivation

oracle support use specific chunk column as a split key

Modifications

  • Modify OracleTableSource#getScanRuntimeProvider by adding a chunkKeyColumn param
  • Add doc about chunk column and permission GRANT ANALYZE ANY
  • Add ITcase UT about using chunk coulmn

@github-actions github-actions bot added docs Improvements or additions to documentation oracle-cdc-connector labels Jan 7, 2024
@gong
Copy link
Contributor Author

gong commented Jan 7, 2024

@leonardBang @GOODBOY008 PTAL

@gong gong force-pushed the feature-oracle-chunkcolumn branch from 73607dc to 213cbc5 Compare January 10, 2024 14:50
@gong
Copy link
Contributor Author

gong commented Jan 20, 2024

@lvyanquan PTAL

@gong gong requested a review from lvyanquan January 24, 2024 02:30
lvyanquan
lvyanquan approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@lvyanquan lvyanquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

leonardBang
leonardBang approved these changes Jan 24, 2024
View reviewed changes
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gong for the contribution, LGTM

@leonardBang leonardBang merged commit 20e44e6 into apache:master Jan 24, 2024
17 checks passed
This was referenced Jan 30, 2024
Closed
Closed
joyCurry30 pushed a commit to joyCurry30/flink-cdc-connectors that referenced this pull request Mar 22, 2024
@gong @joyCurry30
[cdc-connector][oracle] Oracle supports user specific chunk column (a…
4d276e7 
…pache#2976)

This closes apache#2973.
@e-mhui e-mhui mentioned this pull request Apr 22, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leonardBang leonardBang leonardBang approved these changes

@lvyanquan lvyanquan lvyanquan approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to documentation oracle-cdc-connector
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[cdc-connector][oracle] oracle support use specific chunk column as a split key
3 participants
@gong @leonardBang @lvyanquan