-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-35891][cdc-connector][paimon] support dynamic bucket. #3499
Conversation
5669342
to
cd0959e
Compare
The issue id is wrong, plz correct it |
cd0959e
to
367d597
Compare
9ad64e1
to
396245a
Compare
9c1fcf9
to
54cabcd
Compare
54cabcd
to
65f22c0
Compare
4f72b32
to
04aa93b
Compare
04aa93b
to
53f12c0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for @lvyanquan's great work! Just left some general comments.
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/sink/DataSink.java
Show resolved
Hide resolved
...tor-paimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/PaimonHashFunction.java
Show resolved
Hide resolved
...rc/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketAssignOperator.java
Outdated
Show resolved
Hide resolved
...ain/java/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketWrapperChangeEvent.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketWrapperEventKeySelector.java
Outdated
Show resolved
Hide resolved
...aimon/src/main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketWrapper.java
Show resolved
Hide resolved
...n/java/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketWrapperEventTypeInfo.java
Outdated
Show resolved
Hide resolved
...main/java/org/apache/flink/cdc/connectors/paimon/sink/v2/bucket/BucketWrapperFlushEvent.java
Outdated
Show resolved
Hide resolved
...paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/PaimonHashFunctionTest.java
Outdated
Show resolved
Hide resolved
...paimon/src/test/java/org/apache/flink/cdc/connectors/paimon/sink/PaimonHashFunctionTest.java
Show resolved
Hide resolved
Thanks @yuxiqian, addressed your comments. |
The failed case in mysql is unrelated to the change of this pr.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @lvyanquan for the contribution and @yuxiqian for the review, LGTM
Merging... The failed case is not related current PR,I‘ll file a issue ticket to track it |
…aimon sink This closes apache#3499.
support dynamic bucket.