Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-35991][FLINK-36034][transform] Resolve conflicts in transform SQL operator tables #3513

Merged
merged 2 commits into from
Aug 12, 2024

Conversation

yuxiqian
Copy link
Contributor

@yuxiqian yuxiqian commented Aug 7, 2024

This closes FLINK-35991 and FLINK-36034.

Currently, transform operator chains self-defined SqlFunctions and standard function tables, which might be a problem since there are some conflicting function declarations.

Getting rid of SqlStdOperatorTable and declaring supported functions only should resolve this problem.

Also, current implementation unreasonably relies on Flink table planner, causing trouble in Kubernetes deployment mode. Getting rid of it should solve this.

@yuxiqian
Copy link
Contributor Author

yuxiqian commented Aug 7, 2024

cc @aiwenmo

@yuxiqian yuxiqian force-pushed the FLINK-35991 branch 3 times, most recently from c4fcdb1 to 68e2e0d Compare August 12, 2024 06:39
@yuxiqian yuxiqian changed the title [FLINK-35991][runtime] Resolve conflicts in transform SQL operator tables [FLINK-35991][FLINK-36034][transform] Resolve conflicts in transform SQL operator tables Aug 12, 2024
Copy link
Contributor

@leonardBang leonardBang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @yuxiqian for the fix, LGTM, wait the CI green

@leonardBang
Copy link
Contributor

CI passed, merging...

@leonardBang leonardBang merged commit 1042095 into apache:master Aug 12, 2024
2 checks passed
qiaozongmi pushed a commit to qiaozongmi/flink-cdc that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants