[FLINK-35243] Extends schema change event types support #3521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
from
83be39c
to
5b03ad1
Compare
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
3 times, most recently
from
c2b8489
to
b33362c
Compare
|
Marked it as draft for now, need to add more tests to verify if table-level schema change event works as expected. |
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
2 times, most recently
from
f8656bd
to
e277a1c
Compare
github-actions
bot
added
mongodb-cdc-connector
and removed
kafka-pipeline-connector
labels
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
from
e277a1c
to
d8f31b7
Compare
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
from
d8f31b7
to
bb7288a
Compare
|
Rebased & improved test coverage. @leonardBang @ruanhang1993 PTAL |
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
from
bb7288a
to
95ec5b0
Compare
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
from
95ec5b0
to
c2a8bf8
Compare
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
from
5f0fb45
to
7e97e83
Compare
leonardBang
reviewed
Aug 19, 2024
There was a problem hiding this comment.
Thanks @yuxiqian for the contribution, I left some general comments
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/TruncateTableEvent.java
Outdated
Show resolved
Hide resolved
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/DropTableEvent.java
Outdated
Show resolved
Hide resolved
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/DropTableEvent.java
Show resolved
Hide resolved
flink-cdc-common/src/main/java/org/apache/flink/cdc/common/event/SchemaChangeEventVisitor.java
Outdated
Show resolved
Hide resolved
|
Thanks for Leonard's review, I've made the following changes:
|
leonardBang
reviewed
Aug 19, 2024
...eline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/SchemaEvolveE2eITCase.java
Show resolved
Hide resolved
yuxiqian
force-pushed
the
FLINK-35243-NG
branch
from
e137bdf
to
bfcf820
Compare
leonardBang
reviewed
Aug 19, 2024
...eline-e2e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/SchemaEvolveE2eITCase.java
Outdated
Show resolved
Hide resolved
.../org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java
Show resolved
Hide resolved
leonardBang
approved these changes
Aug 19, 2024
|
CI passed, merging... |
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR closes FLINK-35243.
Recreated one since the last PR (#3296) has so many conflicts with
masterand isn't worth rebasing.DropTableEventandTruncateTableEventin pipeline frameworkSchemaChangeEventWithPreSchemainterface, allowing SchemaRegistry backfilling schema before change payload