[FLINK-36092] Fix schema evolution with wildcarded transform rules #3557
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering this is blocking users from using schema evolution with transform blocks, could @leonardBang @aiwenmo please take a look? |
leonardBang
reviewed
Aug 20, 2024
flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/parser/TransformParser.java
Outdated
Show resolved
Hide resolved
leonardBang
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Thanks @yuxiqian for the fix, the change generally looks good to me except one comment
yuxiqian
changed the title
# Conflicts: # flink-cdc-runtime/src/main/java/org/apache/flink/cdc/runtime/operators/transform/PreTransformOperator.java
This was caused by late initialization of `transforms` blocks. `open` isn't early enough since it won't be executed until `initializeState` phase. According to Flink docs, putting data fields initialization phase in `setup` should be suitable.
|
@yuxiqian The CI failed |
|
Seems Postgres and OceanBase CI is hanging, unlikely to be relevant to this PR. |
leonardBang
approved these changes
Aug 22, 2024
yuxiqian
added a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Aug 22, 2024
…ed transform rule This closes apache#3557. (cherry picked from commit 3837887)
leonardBang
pushed a commit
that referenced
this pull request
Aug 27, 2024
…void blocking the main thread This closes #3557
leonardBang
pushed a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Aug 27, 2024
…ed transform rule This closes apache#3557. (cherry picked from commit 3837887)
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
…ed transform rule This closes apache#3557.
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
…void blocking the main thread This closes apache#3557
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, transform doesn't work very well with schema evolution.
The main issue is that TransformOperator (including Pre- and Post-) simply passes all upstream schema change events to downstream, which isn't correct under most cases.
Here's corresponding operations this PR tries to do in various transform rule definitions:
*, ......, *, ......, *