[FLINK-36094] CDC SchemaRegistryRequestHandler should throw exception which is not SchemaEvolveException #3558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… which is not SchemaEvolveException
loserwang1024
force-pushed
the
FLINK-36094
branch
from
8b5bb52
to
1e5bc0d
Compare
|
@leonardBang @yuxiqian @ruanhang1993 , CC, WDYT? |
yuxiqian
reviewed
Aug 20, 2024
There was a problem hiding this comment.
Thanks for @loserwang1024's quick fix, just left some minor comments.
...dc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/schema/SchemaEvolveTest.java
Outdated
Show resolved
Hide resolved
...tor-doris/src/main/java/org/apache/flink/cdc/connectors/doris/sink/DorisMetadataApplier.java
Show resolved
Hide resolved
.../org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java
Outdated
Show resolved
Hide resolved
.../org/apache/flink/cdc/runtime/operators/schema/coordinator/SchemaRegistryRequestHandler.java
Outdated
Show resolved
Hide resolved
done it |
yuxiqian
approved these changes
Aug 20, 2024
...dc-runtime/src/test/java/org/apache/flink/cdc/runtime/operators/schema/SchemaEvolveTest.java
Show resolved
Hide resolved
| @@ -275,6 +277,8 @@ public void resetToCheckpoint(long checkpointId, @Nullable byte[] checkpointData | |||
| throw new IOException( | |||
| "Unrecognized serialization version " + schemaManagerSerializerVersion); | |||
| } | |||
| } catch (Throwable throwable) { | |||
| context.failJob(throwable); | |||
There was a problem hiding this comment.
why not re-throw this throwable here?
...e-tests/src/test/java/org/apache/flink/cdc/pipeline/tests/utils/PipelineTestEnvironment.java
Outdated
Show resolved
Hide resolved
leonardBang
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Thanks @loserwang1024 for the improvement and @yuxiqian for the review +1
yuxiqian
pushed a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Aug 22, 2024
…equestHandler thrown This closes apache#3558. (cherry picked from commit 6205a5a)
leonardBang
pushed a commit
to yuxiqian/flink-cdc
that referenced
this pull request
Aug 27, 2024
…equestHandler thrown This closes apache#3558. (cherry picked from commit 6205a5a)
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
…equestHandler thrown This closes apache#3558.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As shown in https://issues.apache.org/jira/browse/FLINK-36094, Current, SchemaRegistryRequestHandler only throw
SchemaEvolveException, which will not handle the others(like network, oom, or else.