Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-36115][pipeline-connector][mysql] add scan.incremental.newly-added-table.enabled option #3560

Merged
merged 4 commits into from
Aug 22, 2024

Conversation

lvyanquan
Copy link
Contributor

This allow to scan newly table DDL during incremental reading stage.

…ewly-added-table.enabled option to Allow to scan newly table DDL during incremental reading stage.
…added-table.enabled option to Allow to scan newly table during binlog reading stage.
…ewly-added-table.enabled option to Allow to scan newly table DDL during incremental reading stage.
@github-actions github-actions bot added the docs Improvements or additions to documentation label Aug 21, 2024
@@ -128,6 +131,8 @@ public DataSource createDataSource(Context context) {
int connectMaxRetries = config.get(CONNECT_MAX_RETRIES);
int connectionPoolSize = config.get(CONNECTION_POOL_SIZE);
boolean scanNewlyAddedTableEnabled = config.get(SCAN_NEWLY_ADDED_TABLE_ENABLED);
boolean scanIncrementalNewlyAddedTableEnabled =
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
boolean scanIncrementalNewlyAddedTableEnabled =
boolean scanInBinlogPhaseNewlyAddedTableEnabled =

@leonardBang leonardBang changed the title [FLINK-FLINK-36115][pipeline-connector][mysql] add scan.incremental.newly-added-table.enabled option [FLINK-36115][pipeline-connector][mysql] add scan.incremental.newly-added-table.enabled option Aug 21, 2024
@leonardBang
Copy link
Contributor

@Jiabao-Sun @GOODBOY008 Would you like to take a look at this PR if you have time?

…added-table.enabled option to Allow to scan newly table during binlog reading stage.
Copy link
Contributor

@Jiabao-Sun Jiabao-Sun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@leonardBang leonardBang merged commit 565032e into apache:master Aug 22, 2024
23 checks passed
qiaozongmi pushed a commit to qiaozongmi/flink-cdc that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved docs Improvements or additions to documentation mysql-pipeline-connector reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants