-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-36115][pipeline-connector][mysql] add scan.incremental.newly-added-table.enabled option #3560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ewly-added-table.enabled option to Allow to scan newly table DDL during incremental reading stage.
leonardBang
reviewed
Aug 21, 2024
...mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java
Outdated
Show resolved
Hide resolved
...mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/MySqlDataSourceOptions.java
Outdated
Show resolved
Hide resolved
leonardBang
reviewed
Aug 21, 2024
...st/java/org/apache/flink/cdc/connectors/mysql/source/MysqlPipelineNewlyAddedTableITCase.java
Outdated
Show resolved
Hide resolved
…added-table.enabled option to Allow to scan newly table during binlog reading stage.
…ewly-added-table.enabled option to Allow to scan newly table DDL during incremental reading stage.
leonardBang
reviewed
Aug 21, 2024
@@ -128,6 +131,8 @@ public DataSource createDataSource(Context context) { | |||
int connectMaxRetries = config.get(CONNECT_MAX_RETRIES); | |||
int connectionPoolSize = config.get(CONNECTION_POOL_SIZE); | |||
boolean scanNewlyAddedTableEnabled = config.get(SCAN_NEWLY_ADDED_TABLE_ENABLED); | |||
boolean scanIncrementalNewlyAddedTableEnabled = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
boolean scanIncrementalNewlyAddedTableEnabled = | |
boolean scanInBinlogPhaseNewlyAddedTableEnabled = |
leonardBang
changed the title
[FLINK-FLINK-36115][pipeline-connector][mysql] add scan.incremental.newly-added-table.enabled option
[FLINK-36115][pipeline-connector][mysql] add scan.incremental.newly-added-table.enabled option
Aug 21, 2024
@Jiabao-Sun @GOODBOY008 Would you like to take a look at this PR if you have time? |
…added-table.enabled option to Allow to scan newly table during binlog reading stage.
Jiabao-Sun
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
…able.enabled option for MySQL Source This closes apache#3560.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allow to scan newly table DDL during incremental reading stage.