[hotfix][mysql] Fix primary key restraints missing when using inline PRIMARY KEY declaration syntax
#3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…`PRIMARY KEY` declaration syntax # Conflicts: # flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/main/java/org/apache/flink/cdc/connectors/mysql/source/parser/CustomAlterTableParserListener.java # flink-cdc-connect/flink-cdc-pipeline-connectors/flink-cdc-pipeline-connector-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlPipelineITCase.java
lvyanquan
reviewed
Aug 28, 2024
| if (tableEditor.hasPrimaryKey()) { | ||
| builder.primaryKey(tableEditor.primaryKeyColumnNames()); | ||
| } | ||
| changes.add(new CreateTableEvent(toCdcTableId(tableEditor.tableId()), builder.build())); |
There was a problem hiding this comment.
Is this change necessary or for code style standardization？
There was a problem hiding this comment.
I thought it makes more sense to put it inside runIfNotNull block, since referencing tableEditor from the outside implicitly assumes tableEditor is not null.
...or-mysql/src/test/java/org/apache/flink/cdc/connectors/mysql/source/MySqlPipelineITCase.java
Show resolved
Hide resolved
lvyanquan
approved these changes
Aug 28, 2024
leonardBang
approved these changes
Aug 28, 2024
qiaozongmi
pushed a commit
to qiaozongmi/flink-cdc
that referenced
this pull request
Sep 23, 2024
… when using inline `PRIMARY KEY` declaration syntax This closes apache#3579.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, it is possible to parse correct CreateTableEvents from Binlog with the following syntax:
However, inlined primary key declaration syntax is not possible:
This should be resolved by adding missing
enterPrimaryKeyColumnConstrainthandlers inCustomColumnDefinitionParserListener.