-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FLINK-28751][Table SQL/Runtime] Optimize the performance of the json… #20397
Conversation
Do you have any benchmark between the two implementations? |
I have not written a benchmark test for it now, I only run a production test which seen 2~4 times improved. Do you mean add an extra test for it in the flink-benchmark project? @wuchong |
The result shows below:
The results show that the new cache will bring 5~10 times throughputs |
ping @wuchong |
@wuchong any further comments ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
…son path This closes apache#20397
@flinkbot run azure |
Rebase and force pushed |
… functions
What is the purpose of the change
This PR is meant to improve the performance of the built in json functions. The default
LRUCache
used in the JsonPath CacheProvider heavily use the lock which bring the bad performance.Brief change log
JsonPathCache
and set it to theCacheProvider
when load the classVerifying this change
The functionality is covered by the existing tests. I have not written a performance test for it, If needed, I will add one. I manually test the case with the production job, which will have 2~4 times performance improvement.
Does this pull request potentially affect one of the following parts:
@Public(Evolving)
: (no)Documentation