Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FLINK-29038][runtime] Fix unstable case AsyncWaitOperatorTest#testProcessingTimeRepeatedCompleteOrderedWithRetry #20702

Closed
wants to merge 1 commit into from

Conversation

lincoln-lil
Copy link
Contributor

What is the purpose of the change

The failure reason of AsyncWaitOperatorTest#testProcessingTimeRepeatedCompleteOrderedWithRetry maybe the slow execution occurred in internal executor service (which simulate external lookup of IllWrittenOddInputEmptyResultAsyncFunction), we improve the execution deadline from 1s to 10s so as to reduce the failure possiblilty.

Brief change log

improve the execution deadline from 1s to 10s

Verifying this change

AsyncWaitOperatorTest#testProcessingTimeRepeatedCompleteOrderedWithRetry

Does this pull request potentially affect one of the following parts:

  • Dependencies (does it add or upgrade a dependency): (no)
  • The public API, i.e., is any changed class annotated with @public(Evolving): (no)
  • The serializers: (no )
  • The runtime per-record code paths (performance sensitive): (no)
  • Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Kubernetes/Yarn, ZooKeeper: (no)
  • The S3 file system connector: (no)

Documentation

  • Does this pull request introduce a new feature? (no)

…ocessingTimeRepeatedCompleteOrderedWithRetry
Copy link
Contributor

@gaoyunhaii gaoyunhaii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lincoln-lil for the fix! LGTM

@flinkbot
Copy link
Collaborator

flinkbot commented Aug 29, 2022

CI report:

Bot commands The @flinkbot bot supports the following commands:
  • @flinkbot run azure re-run the last Azure build

huangxiaofeng10047 pushed a commit to huangxiaofeng10047/flink that referenced this pull request Nov 3, 2022
…ocessingTimeRepeatedCompleteOrderedWithRetry

This closes apache#20702.
@lincoln-lil lincoln-lil deleted the FLINK-29038 branch February 3, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants