Skip to content

Commit

Permalink
rename
Browse files Browse the repository at this point in the history
  • Loading branch information
jerqi committed Sep 30, 2024
1 parent 92a6f7d commit b034fa7
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 20 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -26,23 +26,23 @@
/** The helper class for {@link Privilege}. */
public class Privileges {

private static final Set<MetadataObject.Type> supportedTableTypes =
private static final Set<MetadataObject.Type> SUPPORTED_TABLE_TYPES =
Sets.newHashSet(
MetadataObject.Type.METALAKE,
MetadataObject.Type.CATALOG,
MetadataObject.Type.SCHEMA,
MetadataObject.Type.TABLE);
private static final Set<MetadataObject.Type> supportedTopicTypes =
private static final Set<MetadataObject.Type> SUPPORTED_TOPIC_TYPES =
Sets.newHashSet(
MetadataObject.Type.METALAKE,
MetadataObject.Type.CATALOG,
MetadataObject.Type.SCHEMA,
MetadataObject.Type.TOPIC);
private static final Set<MetadataObject.Type> supportedSchemaTypes =
private static final Set<MetadataObject.Type> SUPPORTED_SCHEMA_TYPES =
Sets.newHashSet(
MetadataObject.Type.METALAKE, MetadataObject.Type.CATALOG, MetadataObject.Type.SCHEMA);

private static final Set<MetadataObject.Type> supportedFilesetTypes =
private static final Set<MetadataObject.Type> SUPPORTED_FILESET_TYPES =
Sets.newHashSet(
MetadataObject.Type.METALAKE,
MetadataObject.Type.CATALOG,
Expand Down Expand Up @@ -322,7 +322,7 @@ public static UseSchema deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedSchemaTypes.contains(type);
return SUPPORTED_SCHEMA_TYPES.contains(type);
}
}

Expand Down Expand Up @@ -376,7 +376,7 @@ public static CreateTable deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedSchemaTypes.contains(type);
return SUPPORTED_SCHEMA_TYPES.contains(type);
}
}

Expand All @@ -403,7 +403,7 @@ public static SelectTable deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedTableTypes.contains(type);
return SUPPORTED_TABLE_TYPES.contains(type);
}
}

Expand All @@ -430,7 +430,7 @@ public static ModifyTable deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedTableTypes.contains(type);
return SUPPORTED_TABLE_TYPES.contains(type);
}
}

Expand All @@ -457,7 +457,7 @@ public static CreateFileset deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedSchemaTypes.contains(type);
return SUPPORTED_SCHEMA_TYPES.contains(type);
}
}

Expand All @@ -484,7 +484,7 @@ public static ReadFileset deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedFilesetTypes.contains(type);
return SUPPORTED_FILESET_TYPES.contains(type);
}
}

Expand All @@ -511,7 +511,7 @@ public static WriteFileset deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedFilesetTypes.contains(type);
return SUPPORTED_FILESET_TYPES.contains(type);
}
}

Expand All @@ -538,7 +538,7 @@ public static CreateTopic deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedSchemaTypes.contains(type);
return SUPPORTED_SCHEMA_TYPES.contains(type);
}
}

Expand All @@ -565,7 +565,7 @@ public static ConsumeTopic deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedTopicTypes.contains(type);
return SUPPORTED_TOPIC_TYPES.contains(type);
}
}

Expand All @@ -592,7 +592,7 @@ public static ProduceTopic deny() {

@Override
public boolean canBindTo(MetadataObject.Type type) {
return supportedTopicTypes.contains(type);
return SUPPORTED_TOPIC_TYPES.contains(type);
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,13 @@ public class AuthorizationUtils {
static final String ROLE_DOES_NOT_EXIST_MSG = "Role %s does not exist in th metalake %s";
private static final Logger LOG = LoggerFactory.getLogger(AuthorizationUtils.class);
private static final String METALAKE_DOES_NOT_EXIST_MSG = "Metalake %s does not exist";
private static final Set<Privilege.Name> filesetPrivileges =
private static final Set<Privilege.Name> FILESET_PRIVILEGES =
Sets.newHashSet(
Privilege.Name.CREATE_FILESET, Privilege.Name.WRITE_FILESET, Privilege.Name.READ_FILESET);
private static final Set<Privilege.Name> tablePrivileges =
private static final Set<Privilege.Name> TABLE_PRIVILEGES =
Sets.newHashSet(
Privilege.Name.CREATE_TABLE, Privilege.Name.MODIFY_TABLE, Privilege.Name.SELECT_TABLE);
private static final Set<Privilege.Name> topicPrivileges =
private static final Set<Privilege.Name> TOPIC_PRIVILEGES =
Sets.newHashSet(
Privilege.Name.CREATE_TOPIC, Privilege.Name.PRODUCE_TOPIC, Privilege.Name.CONSUME_TOPIC);

Expand Down Expand Up @@ -280,15 +280,15 @@ public static void checkPrivilege(
NameIdentifier identifier = MetadataObjectUtil.toEntityIdent(metalake, object);
NameIdentifier catalogIdent = NameIdentifierUtil.getCatalogIdentifier(identifier);
try {
if (filesetPrivileges.contains(privilege.name())) {
if (FILESET_PRIVILEGES.contains(privilege.name())) {
checkCatalogType(catalogIdent, Catalog.Type.FILESET, privilege);
}

if (tablePrivileges.contains(privilege.name())) {
if (TABLE_PRIVILEGES.contains(privilege.name())) {
checkCatalogType(catalogIdent, Catalog.Type.RELATIONAL, privilege);
}

if (topicPrivileges.contains(privilege.name())) {
if (TOPIC_PRIVILEGES.contains(privilege.name())) {
checkCatalogType(catalogIdent, Catalog.Type.MESSAGING, privilege);
}
} catch (NoSuchCatalogException ne) {
Expand Down

0 comments on commit b034fa7

Please sign in to comment.