Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] Metalake name is cached #1151

Closed
justinmclean opened this issue Dec 14, 2023 · 0 comments · Fixed by #1321
Closed

[Bug report] Metalake name is cached #1151

justinmclean opened this issue Dec 14, 2023 · 0 comments · Fixed by #1321
Assignees
@ch3yne
Milestone
Gravitino 0.4.0

Comments

@justinmclean
Copy link
Member

justinmclean commented Dec 14, 2023 •
edited
Loading

Describe what's wrong

The metalake name in the category title is incorrect after renaming a metalake.

Error message and/or stacktrace

N/A

How to reproduce

In Graviton UI:

  1. Rename a metalake
  2. Click on metalake then a category.

Additional context

No response
@jerryshao jerryshao added this to the Gravitino 0.4.0 milestone Dec 14, 2023
@ch3yne ch3yne mentioned this issue Jan 4, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 4, 2024
@ch3yne
[#1151] fix(UI): Fix status cache after modified a Metalake (#1321)
449a94b 
### What changes were proposed in this pull request?

Fix the issue with the status cache after modifying Metalake.

#### Before:
1. rename a metalake
<img width="480" alt="test2-test3"
src="https://github.com/datastrato/gravitino/assets/17310559/c4f24dd8-9e07-4942-9f40-45c8b375bec6">

2. click `create metalake` button
<img width="480" alt="update-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/4fcc1040-8f91-4dd5-b62a-30c44c5a1b82">

It should be `create dialog`, but displays `update dialog`.

#### After:
when click `create metalake` button, correctly display `create dialog`.
<img width="480" alt="create-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/d833a7a7-d6cd-45ca-9e99-5156c68e5f10">


### Why are the changes needed?

Fix: #1151 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
github-actions bot pushed a commit that referenced this issue Jan 4, 2024
@ch3yne @web-flow
[#1151] fix(UI): Fix status cache after modified a Metalake (#1321)
bd0ae0c 
### What changes were proposed in this pull request?

Fix the issue with the status cache after modifying Metalake.

#### Before:
1. rename a metalake
<img width="480" alt="test2-test3"
src="https://github.com/datastrato/gravitino/assets/17310559/c4f24dd8-9e07-4942-9f40-45c8b375bec6">

2. click `create metalake` button
<img width="480" alt="update-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/4fcc1040-8f91-4dd5-b62a-30c44c5a1b82">

It should be `create dialog`, but displays `update dialog`.

#### After:
when click `create metalake` button, correctly display `create dialog`.
<img width="480" alt="create-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/d833a7a7-d6cd-45ca-9e99-5156c68e5f10">


### Why are the changes needed?

Fix: #1151 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A
@github-actions github-actions bot mentioned this issue Jan 4, 2024
Merged
jerryshao pushed a commit that referenced this issue Jan 4, 2024
@github-actions @ch3yne
[#1151] fix(UI): Fix status cache after modified a Metalake (#1325)
3f40349 
### What changes were proposed in this pull request?

Fix the issue with the status cache after modifying Metalake.

#### Before:
1. rename a metalake
<img width="480" alt="test2-test3"
src="https://github.com/datastrato/gravitino/assets/17310559/c4f24dd8-9e07-4942-9f40-45c8b375bec6">

2. click `create metalake` button
<img width="480" alt="update-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/4fcc1040-8f91-4dd5-b62a-30c44c5a1b82">

It should be `create dialog`, but displays `update dialog`.

#### After:
when click `create metalake` button, correctly display `create dialog`.
<img width="480" alt="create-metalake"
src="https://github.com/datastrato/gravitino/assets/17310559/d833a7a7-d6cd-45ca-9e99-5156c68e5f10">


### Why are the changes needed?

Fix: #1151 

### Does this PR introduce _any_ user-facing change?

N/A

### How was this patch tested?

N/A

Co-authored-by: CHEYNE <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ch3yne ch3yne

Labels
None yet
Projects
None yet
Milestone
Gravitino 0.4.0
Development

Successfully merging a pull request may close this issue.

[#1151] fix(UI): Fix status cache after modified a Metalake ch3yne/gravitino
3 participants
@justinmclean @jerryshao @ch3yne