Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug report] Gravitino-trino-connector is incompatible with Trino-435 #2376

Closed
theoryxu opened this issue Feb 28, 2024 · 8 comments · Fixed by #2391
Closed

[Bug report] Gravitino-trino-connector is incompatible with Trino-435 #2376

theoryxu opened this issue Feb 28, 2024 · 8 comments · Fixed by #2391
Assignees
Labels
bug Something isn't working

Comments

@theoryxu
Copy link
Contributor

theoryxu commented Feb 28, 2024

Version

main branch

Describe what's wrong

Hello fellows

There are some problems when gravitino-trino-connector(0.4.0) is working with Trino-435. I guess Trino-435 has some new interfaces that the connector has not yet implemented. Error information is as follows.

Error message and/or stacktrace

image

How to reproduce

0.4.0 or above

Additional context

No response

@theoryxu theoryxu added the bug Something isn't working label Feb 28, 2024
@jerryshao
Copy link
Contributor

@diqiu50 can you please take a look at this?

@diqiu50
Copy link
Contributor

diqiu50 commented Feb 28, 2024

In the directory of the graviton-trino-connector plugin, some Trino jars have different versions than the Trino server.

ls   trino-*
-rw-r--r--@ 1 ice  staff   36737 Feb 28 16:14 trino-cache-426.jar
-rw-r--r--@ 1 ice  staff   20523 Feb 28 16:14 trino-matching-426.jar
-rw-r--r--  1 ice  staff  317755 Feb 28 16:24 trino-plugin-toolkit-426.jar
-rw-r--r--@ 1 ice  staff  976399 Feb 28 16:14 trino-spi-426.jar

I replaced the trino-plugin-toolkit-426.jar with trino-plugin-toolkit-435.jar, and now the graviton-connector works on Trino-435

So we need to find a way to solve this version issue.

@jerryshao
Copy link
Contributor

I think you should not include trino dependencies, perhaps you may need to change the dependency from implementation to compileOnly?

@yuqi1129
Copy link
Contributor

I think you should not include trino dependencies, perhaps you may need to change the dependency from implementation to compileOnly?

Yes, he is going to remove all trino-related jars from the runtime class path.

@theoryxu
Copy link
Contributor Author

theoryxu commented Mar 4, 2024

@diqiu50 Hi bro, just for your information. There is another case that shows a different error stack trace.

When the node is a worker rather than a coodirator, the error msg is the following:

image

@diqiu50
Copy link
Contributor

diqiu50 commented Mar 4, 2024

Ok, I will test it later

@jerryshao
Copy link
Contributor

jerryshao commented Mar 5, 2024

@diqiu50 Hi bro, just for your information. There is another case that shows a different error stack trace.

When the node is a worker rather than a coodirator, the error msg is the following:

image

Can you please create a separate issue to track this bug? @theoryxu

jerryshao pushed a commit that referenced this issue Mar 5, 2024
…e with Trino-435 (#2391)

### What changes were proposed in this pull request?

Remove the Trino runtime dependency to avoid version incompatibility.
Our Trino-connector uses Trino-426 for development. The
AllowAllAccessControl dependency, trino-toolkit-426.jar, causes
compatibility issues with Trino-426

### Why are the changes needed?
Fix: #2376

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

Manually testing in Trino-435
@theoryxu
Copy link
Contributor Author

theoryxu commented Mar 5, 2024

@jerryshao, of course: #2428

diqiu50 added a commit to diqiu50/gravitino that referenced this issue Mar 5, 2024
…patible with Trino-435 (apache#2391)

### What changes were proposed in this pull request?

Remove the Trino runtime dependency to avoid version incompatibility.
Our Trino-connector uses Trino-426 for development. The
AllowAllAccessControl dependency, trino-toolkit-426.jar, causes
compatibility issues with Trino-426

### Why are the changes needed?
Fix: apache#2376

### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

Manually testing in Trino-435
jerryshao pushed a commit that referenced this issue Mar 5, 2024
…incompatible with Trino-435 (#2429)

### What changes were proposed in this pull request?

Remove the Trino runtime dependency to avoid version incompatibility.
Our Trino-connector uses Trino-426 for development. The
AllowAllAccessControl dependency, trino-toolkit-426.jar, causes
compatibility issues with Trino-426

### Why are the changes needed?

Fix: #2376


### Does this PR introduce _any_ user-facing change?

NO

### How was this patch tested?

Manually testing in Trino-435
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
4 participants