-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[#4370]feat(iceberg): support view interface for Iceberg REST server #4937
Conversation
@FANNG1 please help to review, Thanks. |
...erver/src/test/java/org/apache/gravitino/iceberg/service/rest/TestIcebergViewOperations.java
Show resolved
Hide resolved
@theoryxu , thanks for the PR, after supporting views, could Spark create the view in the Iceberg REST catalog? If yes, could you add corresponding integration test? |
Sure, I tested it in an internal environment and will add an integration test soon. |
@FANNG1 Integration tests have been added. Please review. Thanks! |
...server/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTServiceIT.java
Outdated
Show resolved
Hide resolved
LGTM except one comment, @theoryxu could you fix the ci error? |
...er/src/test/java/org/apache/gravitino/iceberg/integration/test/IcebergRESTJdbcCatalogIT.java
Show resolved
Hide resolved
@theoryxu , merged to main, thanks for your contribution. |
What changes were proposed in this pull request?
support view interface for Iceberg REST server
Why are the changes needed?
Fix: #4370
Does this PR introduce any user-facing change?
no
How was this patch tested?