Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#4370]feat(iceberg): support view interface for Iceberg REST server #4937

Merged
merged 16 commits into from
Oct 8, 2024

Conversation

theoryxu
Copy link
Contributor

What changes were proposed in this pull request?

support view interface for Iceberg REST server

Why are the changes needed?

Fix: #4370

Does this PR introduce any user-facing change?

no

How was this patch tested?

  1. add UT
  2. manual test

@theoryxu theoryxu marked this pull request as ready for review September 19, 2024 08:54
@theoryxu
Copy link
Contributor Author

@FANNG1 please help to review, Thanks.

@FANNG1
Copy link
Contributor

FANNG1 commented Sep 20, 2024

@theoryxu , thanks for the PR, after supporting views, could Spark create the view in the Iceberg REST catalog? If yes, could you add corresponding integration test?

@theoryxu
Copy link
Contributor Author

@theoryxu , thanks for the PR, after supporting views, could Spark create the view in the Iceberg REST catalog? If yes, could you add corresponding integration test?

Sure, I tested it in an internal environment and will add an integration test soon.

@theoryxu
Copy link
Contributor Author

@FANNG1 Integration tests have been added. Please review. Thanks!

@FANNG1
Copy link
Contributor

FANNG1 commented Sep 27, 2024

LGTM except one comment, @theoryxu could you fix the ci error?

FANNG1
FANNG1 previously approved these changes Sep 30, 2024
docs/iceberg-rest-service.md Outdated Show resolved Hide resolved
docs/iceberg-rest-service.md Outdated Show resolved Hide resolved
docs/iceberg-rest-service.md Outdated Show resolved Hide resolved
@FANNG1 FANNG1 merged commit 13d1684 into apache:main Oct 8, 2024
26 checks passed
@FANNG1
Copy link
Contributor

FANNG1 commented Oct 8, 2024

@theoryxu , merged to main, thanks for your contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Subtask] support view interface for Iceberg REST server
2 participants