[#5547] feat(core): support schema pre event for Gravitino server #5559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FANNG1
reviewed
Nov 13, 2024
| private final SchemaInfo createdSchemaRequest; | ||
|
|
||
| public CreateSchemaPreEvent( | ||
| String user, NameIdentifier identifier, SchemaInfo createdSchemaRequest) { |
There was a problem hiding this comment.
createdSchemaRequest -> createSchemaRequest?
| * @return A {@link SchemaInfo} instance encapsulating the comprehensive details of the newly | ||
| * created schema. | ||
| */ | ||
| public SchemaInfo createdSchemaInfo() { |
There was a problem hiding this comment.
createdSchemaInfo -> createSchemaRequest?
| @@ -30,7 +30,7 @@ public class AlterTablePreEvent extends TablePreEvent { | |||
|
|
|||
| public AlterTablePreEvent(String user, NameIdentifier identifier, TableChange[] tableChanges) { | |||
| super(user, identifier); | |||
| this.tableChanges = tableChanges; | |||
| this.tableChanges = tableChanges.clone(); | |||
There was a problem hiding this comment.
In post-event, the objects are cloned to prevent the user from changing the object. But in pre-event, I prefer to relax the constraint to allow users to make changes to in inject some custom logic.
|
@orenccl thanks for your PR, LGTM except minor comments. |
|
Hi @FANNG1 |
FANNG1
approved these changes
Nov 13, 2024
jerryshao
changed the title
|
@orenccl merged to main, thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
add schema pre event to event listener
Why are the changes needed?
Close: #5547
Does this PR introduce any user-facing change?
no
How was this patch tested?
add Unit Test