[#5596] Improvement(filesystem-hadoop3): Override the addDelegationTokens method to fix the token expired issue
#5597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xloya
changed the title
addDelegationTokens method to fix the token expired issueaddDelegationTokens method to fix the token expired issue
jerryshao
reviewed
Nov 18, 2024
| @Override | ||
| public Token<?>[] addDelegationTokens(String renewer, Credentials credentials) { | ||
| List<Token<?>> tokenList = Lists.newArrayList(); | ||
| for (FileSystem fileSystem : internalFileSystemCache.asMap().values()) { |
There was a problem hiding this comment.
Shall we filter out some filesystems that doesn't have delegation token mechanism? For example, like local filesystem, S3, etc.
There was a problem hiding this comment.
I think we don't need to do filtering, please see the specific code call:
- The
getCanonicalServiceNameandgetChildFileSystemsmethods will always returnnullin the default implementations. - Some FileSystems do not support token will also override the
getCanonicalServiceNameto returnnulldirectly(like S3AFileSystem, AliyunOSSFileSystem)
There was a problem hiding this comment.
I see, thanks for the explanation.
jerryshao
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Pass the delegation token to the FileSystem managed by GVFS.
Why are the changes needed?
Fix: #5596
How was this patch tested?
Tests it in the production environment.