HIVE-28560: AssertionError for jdbc queries because of incorrec… #5491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t expectedRel in SqlImplementor
difin
reviewed
Oct 8, 2024
Comment on lines
1
to
5
| --!qt:database:postgres:q_test_tpcds_tables.sql | ||
|
|
||
| CREATE EXTERNAL TABLE IF NOT EXISTS `date_dim`( | ||
| `d_date_sk` int, | ||
| `d_date_id` string, |
There was a problem hiding this comment.
I don't understand the purpose of including this file q_test_tpcds_tables.sql here.
The same tables that are created by that file are also created in this q-test.
There was a problem hiding this comment.
q_test_tpcds_tables.sql creates them in a postgres database in a docker container.
In this file, we create external tables for the jdbc tables, and eventually use these external tables for running qtests.
asf-ci-hive
added
tests pending
tests passed
and removed
tests unstable
tests pending
labels
zabetak
requested changes
Oct 10, 2024
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/jdbc/HiveJdbcImplementor.java
Outdated
Show resolved
Hide resolved
soumyakanti3578
changed the title
|
ryukobayashi
pushed a commit
to ryukobayashi/hive
that referenced
this pull request
Oct 15, 2024
…le contains LIMIT (Soumyakanti Das reviewed by Stamatis Zampetakis) Close apache#5491
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…t expectedRel in SqlImplementor
What changes were proposed in this pull request?
https://issues.apache.org/jira/browse/HIVE-28560
Call
setFetchbefore the expectedRel is changed to aProjectWhy are the changes needed?
We get an
AssertionErrorotherwiseDoes this PR introduce any user-facing change?
No
Is the change a dependency upgrade?
No
How was this patch tested?