[Bug]: "Stream lookup": "Get lookup fields" and "Get fields" are flipped

[gertwieland]

Apache Hop version?

2.5

Java version?

openjdk 11.0.19 2023-04-18 OpenJDK Runtime Environment OpenLogic-OpenJDK (build 11.0.19+7-adhoc..jdk11u) OpenJDK 64-Bit Server VM OpenLogic-OpenJDK (build 11.0.19+7-adhoc..jdk11u, mixed mode)

Operating system

Windows

What happened?

In the "Stream Lookup" field, I would expect the "Get Lookup fields" to pull the "Lookup fields", but it doesn't. Instead, it pulls the "Fields to retrieve".

But the "Get Fields" button pulls the "Lookup fields".

I think this should be the opposite.

Issue Priority

Priority: 3

Issue Component

Component: Hop Gui

[harrisward]

I think its right but a little confusion as the Get Lookup Fields Means "Get the fields to lookup from the Lookup Transform". Maybe the names of the buttons could be a bit better? Like "Get Key Fields" for the look up values and "Get Lookup Fields" for the fields to return to the primary transform

[hansva]

I agree that the naming is confusing.
what do you think about the following:
Get fields -> Get return fields
Get lookup fields -> get lookup key fields

?

[hansva]

.take-issue

[gertwieland]

I think the "Get lookup fields" should refer to the "LookupField" column in the upper part.

Then, in the lower part, it reads "Specify fields to retrieve". Maybe the button could just say "Get fields to retrieve"?

My idea is that this way the text in the headers matches the text on the buttons.

[nadment]

My proposal:
Get fields -> Get key fields
Get lookup fields -> Get fields to retrieve

[usbrandon]

I agree with that and also adding the word 'key' "Get key fields" to let it contextualize what happens.

[nadment]

It's a little clearer this way ?

[usbrandon]

"Get key fields" and "Get return fields". I would just make the case match, but it is much clearer.

[hansva]

Has been aligned: