Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: Transform WorkflowExecutor send HopExtensionPoint.WorkflowStart twice #3769

Closed
nadment opened this issue Mar 31, 2024 · 0 comments · Fixed by #3906
Closed

[Bug]: Transform WorkflowExecutor send HopExtensionPoint.WorkflowStart twice #3769

nadment opened this issue Mar 31, 2024 · 0 comments · Fixed by #3906
Assignees
@nadment
Labels
bug P3 Nice to have Transforms Workflows
Milestone
2.9

Comments

@nadment
Copy link
Contributor

nadment commented Mar 31, 2024

Apache Hop version?

2.8.0-SNAPSHOT

Java version?

Java 11

Operating system

Windows

What happened?

The extension point is already called in the Workflow.startExecution() method, but the WorkflowExecutor transformation also sends a HopExtensionPoint.WorkflowStart.

What's more, in this case the executionStartDate is not yet defined when the WorkflowStart extension point is received.

I suggest deleting lines 225,226

Code from WorkflowExecutor
image

Issue Priority

Priority: 3

Issue Component

Component: Transforms
@github-actions github-actions bot added the P3 Nice to have label Mar 31, 2024
@nadment nadment self-assigned this May 1, 2024
nadment added a commit to nadment/hop that referenced this issue May 3, 2024
@nadment
Transform WorkflowExecutor send HopExtensionPoint.WorkflowStart
8c8a9fb 
twice apache#3769
@nadment nadment linked a pull request May 3, 2024 that will close this issue
WorkflowExecutor send HopExtensionPoint.WorkflowStart twice #3769 #3906
Merged
nadment added a commit to nadment/hop that referenced this issue May 3, 2024
@nadment
Transform WorkflowExecutor send HopExtensionPoint.WorkflowStart
a0e8807 
twice apache#3769
hansva added a commit that referenced this issue May 7, 2024
@hansva
Merge pull request #3906 from nadment/3769
b9207d6 
WorkflowExecutor send HopExtensionPoint.WorkflowStart twice #3769
@hansva hansva added this to the 2.9 milestone May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nadment nadment

Labels
bug P3 Nice to have Transforms Workflows
Projects
None yet
Milestone
2.9
Development

Successfully merging a pull request may close this issue.

WorkflowExecutor send HopExtensionPoint.WorkflowStart twice #3769 nadment/hop
2 participants
@hansva @nadment