Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Fix HOP_PLATFORM_RUNTIME=Server in hop-server.bat #3773

Closed
nadment opened this issue Apr 2, 2024 · 2 comments · Fixed by #3774
Closed

[Bug]: Fix HOP_PLATFORM_RUNTIME=Server in hop-server.bat #3773

nadment opened this issue Apr 2, 2024 · 2 comments · Fixed by #3774
Assignees
Labels
Milestone

Comments

@nadment
Copy link
Contributor

nadment commented Apr 2, 2024

Apache Hop version?

2.8.0-SNAPSHOT

Java version?

Java 11

Operating system

Windows

What happened?

Fix HOP_PLATFORM_RUNTIME=Server in hop-server.bat

Issue Priority

Priority: 3

Issue Component

Component: Hop Server

@nadment nadment self-assigned this Apr 2, 2024
@github-actions github-actions bot added the P3 Nice to have label Apr 2, 2024
nadment added a commit to nadment/hop that referenced this issue Apr 2, 2024
@nadment nadment linked a pull request Apr 2, 2024 that will close this issue
@hansva
Copy link
Contributor

hansva commented Apr 2, 2024

does this actually change anything? I mean code/functionality wise?

@nadment
Copy link
Contributor Author

nadment commented Apr 2, 2024

I just discovered this error in the BAT by accident, when I was looking for the relevant attributes for OpenTelementry.
i.e.: Const.getHopPlatformRuntime().

I'm not sure, maybe disable double buffering when generating the graph image on a Windows server.

// Do double buffering to prevent flickering on Windows
boolean needsDoubleBuffering = Const.isWindows() && "GUI".equalsIgnoreCase(Const.getHopPlatformRuntime());

hansva added a commit that referenced this issue Apr 3, 2024
Fix HOP_PLATFORM_RUNTIME=Server in hop-server.bat #3773
@hansva hansva added this to the 2.9 milestone Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants