Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #4341: Use correct logging and hide private Methods as fake data types #4347

Merged

Conversation

vdwals
Copy link
Contributor

@vdwals vdwals commented Sep 23, 2024

  1. NullPointer Exception fix: Changed logging from log.error() to logError() since log is not available in FakeMeta.class.

  2. Fix reason for error log: When generating the available Options in FakeDialog.class, private Methods are listed as well. This results into the option, to select a private message and the error, that this method can not be called or is not available. Therefore I added a filter to exclude private Methods from the list of fake topics.


Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:

  • Run mvn clean install apache-rat:check to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
  • If you have a group of commits related to the same change, please squash your commits into one and force push your branch using git rebase -i.
  • Mention the appropriate issue in your description (for example: addresses #123), if applicable.

To make clear that you license your contribution under the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

…Error() since log is not available in FakeMeta.class.

2. Fix reason for error log: When generating the available Options in FakeDialog.class, private Methods are listed as well. This results into the option, to select a private message and the error, that this method can not be called or is not available. Therefore I added a filter to exclude private Methods from the list of fake topics.
@hansva
Copy link
Contributor

hansva commented Sep 23, 2024

Thanks @vdwals !

@hansva
Copy link
Contributor

hansva commented Sep 23, 2024

A small fyi. You can assign tickets to yourself using the same command we use.
This way we know when you will be working on it.

@hansva hansva merged commit c2c9a55 into apache:main Sep 24, 2024
2 checks passed
@vdwals vdwals deleted the bugfix/4341_nullPointerException_in_fakeData branch September 24, 2024 12:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants