Make the 'log' object private in ActionBase and BaseTransformMeta #4348

[nadment]

No description provided.

[hansva]

In the Integration tests I am getting error lines but they are not stopping the execution (also not getting a full stacktrace):
at org.apache.hop.pipeline.transforms.tableoutput.TableOutput.isRowLevel(TableOutput.java:431)
Will have to see if we can find the cause and if there are more of these

[hansva]

Ah, the issue is very obvious....

hop/plugins/transforms/tableoutput/src/main/java/org/apache/hop/pipeline/transforms/tableoutput/TableOutput.java

Lines 429 to 432 in f91237d

	@Override
	public boolean isRowLevel() {
	return log.isRowLevel();
	}

[nadment]

This case should neither compile nor pass unit tests, and yet I'm sure I've tested a complete and clean installation. A mystery?

[hansva]

sorry the link is coming from the master branch which does not have your changes yet.
the actual code is.

  @Override
  public boolean isRowLevel() {
    return isRowLevel();
  }

Which is valid code and compiles but it's just a never-ending self reference

[nadment]

I'm going to temporarily put the methods in final to find these cases.

[nadment]

TableOutput is the only case I've found with an infinite loop. There is a special case with Janino that overrides the logXXX() methods, but it seems OK.