update

apache · Jul 4, 2023 · 8f705c8 · 8f705c8
1 parent 41b3970
commit 8f705c8
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/analytic_engine/src/sst/parquet/writer.rs b/analytic_engine/src/sst/parquet/writer.rs
@@ -358,6 +358,8 @@ mod tests {
         table_options::{self, StorageFormatHint},
     };
 
+    // TODO(xikai): add test for reverse reader
+
     #[test]
     fn test_parquet_build_and_read() {
         init_log_for_test();

diff --git a/table_engine/src/memory.rs b/table_engine/src/memory.rs
@@ -244,8 +244,8 @@ fn build_column_block<'a, I: Iterator<Item = &'a Datum>>(
     data_type: &DatumKind,
     iter: I,
 ) -> stream::Result<ColumnBlock> {
-    // TODO(tanruixiang) : ensure there don't use is_dictionary and the datum.clone() is necessary
-    // ?
+    // TODO(tanruixiang) : ensure there don't use is_dictionary and the
+    // datum.clone() is necessary ?
     let mut builder = ColumnBlockBuilder::with_capacity(data_type, iter.size_hint().0, false);
     for datum in iter {
         builder