Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: sequence overflow when dropping a table using a message queue as WAL #1550

Merged
merged 2 commits into from
Aug 2, 2024
Merged

fix: sequence overflow when dropping a table using a message queue as WAL #1550

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0fc9fc6
fix: sequence overflow when dropping a table using a message queue as…
chunshao90 Aug 2, 2024
6e0f3aa
refactor by CR
chunshao90 Aug 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions src/wal/src/message_queue_impl/wal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
use std::sync::Arc;

use async_trait::async_trait;
use common_types::SequenceNumber;
use common_types::{SequenceNumber, MAX_SEQUENCE_NUMBER};
use generic_error::BoxError;
use message_queue::{kafka::kafka_impl::KafkaImpl, ConsumeIterator, MessageQueue};
use runtime::Runtime;
Expand Down Expand Up @@ -70,8 +70,13 @@ impl<M: MessageQueue> WalManager for MessageQueueImpl<M> {
location: WalLocation,
sequence_num: SequenceNumber,
) -> Result<()> {
let delete_to_sequence_num = if sequence_num < MAX_SEQUENCE_NUMBER {
sequence_num + 1
} else {
MAX_SEQUENCE_NUMBER
};
self.0
.mark_delete_to(location, sequence_num + 1)
.mark_delete_to(location, delete_to_sequence_num)
.await
.box_err()
.context(Delete)
Expand Down
Loading