HTTPCORE-727 (follow-up): async HTTP/1.1 protocol handler fails to co…

…unt bytes transferred while flushing session buffer when writing out a message head or suspending session output.
apache · Nov 2, 2022 · 8fabd3d · 8fabd3d
1 parent 6023622
commit 8fabd3d
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java b/httpcore5/src/main/java/org/apache/hc/core5/http/impl/nio/AbstractHttp1StreamDuplexer.java
@@ -446,7 +446,10 @@ void commitMessageHead(
             }
             outgoingMessageWriter.reset();
             if (flushMode == FlushMode.IMMEDIATE) {
-                outbuf.flush(ioSession);
+                final int bytesWritten = outbuf.flush(ioSession);
+                if (bytesWritten > 0) {
+                    outTransportMetrics.incrementBytesTransferred(bytesWritten);
+                }
             }
             ioSession.setEvent(EventMask.WRITE);
         } finally {
@@ -479,7 +482,10 @@ void suspendSessionOutput() throws IOException {
         ioSession.getLock().lock();
         try {
             if (outbuf.hasData()) {
-                outbuf.flush(ioSession);
+                final int bytesWritten = outbuf.flush(ioSession);
+                if (bytesWritten > 0) {
+                    outTransportMetrics.incrementBytesTransferred(bytesWritten);
+                }
             } else {
                 ioSession.clearEvent(SelectionKey.OP_WRITE);
             }