Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-2662] Downloads from Nexus Pentaho repo taking too long #3901

Merged
merged 3 commits into from
Nov 1, 2021

Conversation

codope
Copy link
Member

@codope codope commented Nov 1, 2021

What is the purpose of the pull request

https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release is unavailable to serve any requests. We are removing the url from pom as we confirmed that all jars are available in other nexus repository urls.

Brief change log

(for example:)

  • Modify AnnotationLocation checkstyle rule in checkstyle.xml

Verify this pull request

(Please pick either of the following options)

This pull request is a trivial rework / code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end.
  • Added HoodieClientWriteTest to verify the change.
  • Manually verified the change by running a job locally.

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link

hudi-bot commented Nov 1, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run travis re-run the last Travis build
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan
Copy link
Contributor

nsivabalan commented Nov 1, 2021

I inspected every jar thats getting delayed with pentaho. I could confirm that we can find every jar of interest in other nexus domains.


https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/apache/flink/force-shading/1.12.1/force-shading-1.12.1-sources.jar

https://repo.maven.apache.org/maven2/org/apache/flink/force-shading/1.12.1/

https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/apache/flink/flink-shaded-guava/18.0-12.0/flink-shaded-guava-18.0-12.0-sources.jar

https://repo.maven.apache.org/maven2/org/apache/flink/flink-shaded-guava/18.0-12.0/


Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/apache/flink/flink-shaded-asm-7/7.1-12.0/flink-shaded-asm-7-7.1-12.0-sources.jar

https://repo.maven.apache.org/maven2/org/apache/flink/flink-shaded-asm-7/7.1-12.0/


Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/apache/flink/force-shading/1.13.1/force-shading-1.13.1-sources.jar

https://repo.maven.apache.org/maven2/org/apache/flink/force-shading/1.13.1/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/tomcat/jasper-runtime/5.5.23/jasper-runtime-5.5.23-sources.jar
https://repo.maven.apache.org/maven2/tomcat/jasper-runtime/5.5.23/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/xmlenc/xmlenc/0.52/xmlenc-0.52-sources.jar
https://repo.maven.apache.org/maven2/xmlenc/xmlenc/0.52/


Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/stax/stax-api/1.0.1/stax-api-1.0.1-sources.jar
https://repo.maven.apache.org/maven2/stax/stax-api/1.0.1/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/commons-beanutils/commons-beanutils-core/1.8.0/commons-beanutils-core-1.8.0-sources.jar
https://repo.maven.apache.org/maven2/commons-beanutils/commons-beanutils-core/1.8.0/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/apache/hudi/hudi-hadoop-sparkworker-docker/0.10.0-SNAPSHOT/hudi-hadoop-sparkworker-docker-0.10.0-SNAPSHOT-sources.jar


Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/apache/curator/apache-curator/2.7.1/apache-curator-2.7.1-sources.jar
https://repo.maven.apache.org/maven2/org/apache/curator/apache-curator/2.7.1/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/apache/velocity/velocity/1.5/velocity-1.5-sources.jar
https://repo.maven.apache.org/maven2/org/apache/velocity/velocity/1.5/


Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/javax/servlet/jsp-api/2.0/jsp-api-2.0-sources.jar
https://repo.maven.apache.org/maven2/javax/servlet/jsp-api/2.0/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/tomcat/jasper-compiler/5.5.23/jasper-compiler-5.5.23-sources.jar
https://repo.maven.apache.org/maven2/tomcat/jasper-compiler/5.5.23/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/org/apache/thrift/libfb303/0.9.3/libfb303-0.9.3-sources.jar
https://repo.maven.apache.org/maven2/org/apache/thrift/libfb303/0.9.3/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/com/google/code/findbugs/jsr305/1.3.9/jsr305-1.3.9-sources.jar
https://repo.maven.apache.org/maven2/com/google/code/findbugs/jsr305/1.3.9/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/io/confluent/kafka-schema-registry-client/5.3.4/kafka-schema-registry-client-5.3.4-sources.jar
https://packages.confluent.io/maven/io/confluent/kafka-schema-registry-client/5.3.4/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/io/confluent/common-utils/5.3.4/common-utils-5.3.4-sources.jar
https://packages.confluent.io/maven/io/confluent/common-utils/5.3.4/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/io/confluent/common-config/5.3.4/common-config-5.3.4-sources.jar
https://packages.confluent.io/maven/io/confluent/common-config/5.3.4/

Downloading from pentaho.org: https://public.nexus.pentaho.org/repository/proxy-public-3rd-party-release/io/confluent/kafka-avro-serializer/5.3.4/kafka-avro-serializer-5.3.4-sources.jar
https://packages.confluent.io/maven/io/confluent/kafka-avro-serializer/5.3.4/

Once the CI succeeds, we should be good to go ahead and land this in.

@nsivabalan
Copy link
Contributor

@hudi-bot azure run

@nsivabalan
Copy link
Contributor

@hudi-bot azure run

@nsivabalan nsivabalan changed the title [MINOR] Downloads from Nexus Pentaho repo taking too long [HUDI-2662] Downloads from Nexus Pentaho repo taking too long Nov 1, 2021
@nsivabalan
Copy link
Contributor

@hudi-bot azure run

@nsivabalan nsivabalan merged commit 5302b9a into apache:master Nov 1, 2021
@@ -165,6 +165,10 @@ private void initIfNeeded() {
logRecords.put(entry.getKey(), entry.getValue());
}
}
} else {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsivabalan @codope why are these changes needed again?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a test was failing in CI and so I fixed it in this patch. Did not want to land this patch with failing CI. I thought of putting up a separate patch, but the other one will depend on this patch since tests might time out.

@nsivabalan
Copy link
Contributor

I removed the commented out lines in root pom in here. sorry about that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants