Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed RAT config for "hudi-utilities-bundle" to ignore transient build-bound artifiacts #3909

Merged
merged 1 commit into from
Nov 3, 2021

Conversation

alexeykudinkin
Copy link
Contributor

Tips

What is the purpose of the pull request

This PR fixes RAT Maven plugin configuration to make sure that running mvn clean package install isn't having issues with RAT plugin complaining about transient files lacking Apache license attribution

Example failure when running mvn clean package -DskipTests -Dspark3 -Dscala.usejavacp=true

[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.12:check (default) on project hudi-utilities-bundle_2.12: Too many files with unapproved license: 4 See RAT report in: /Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/rat.txt -> [Help 1]

Files RAT is complaining about (lacking the license header)

Files with unapproved licenses:

  /Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/rat.txt
  /Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
  /Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst
  /Users/alexey.kudinkin/code/github/apache/hudi/packaging/hudi-utilities-bundle/target/maven-archiver/pom.properties

Brief change log

  • Fixing RAT plugin config, replicating one from root pom.xml (stripping license configuration part)

Verify this pull request

This pull request is a trivial rework / code cleanup without any test coverage.

This change verified with running successfully mvn clean package -DskipTests -Dspark3 -Dscala.usejavacp=true

Committer checklist

  • Has a corresponding JIRA in PR title & commit

  • Commit message is descriptive of the change

  • CI is green

  • Necessary doc changes done or have another open PR

  • For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.

@hudi-bot
Copy link

hudi-bot commented Nov 2, 2021

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run travis re-run the last Travis build
  • @hudi-bot run azure re-run the last Azure build

@nsivabalan
Copy link
Contributor

thanks for the fix!

@nsivabalan nsivabalan merged commit b12a25b into apache:master Nov 3, 2021
@Zouxxyy
Copy link
Contributor

Zouxxyy commented Nov 6, 2022

I still have this problem, just like this:

[ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (default) on project hudi-utilities-bundle_2.11: Too many files with unapproved license: 4 See RAT report in: xxx/packaging/hudi-utilities-bundle/target/rat.txt -> [Help 1]

and in rat.txt:

Files with unapproved licenses:

xxx/packaging/hudi-utilities-bundle/target/rat.txt
xxx/packaging/hudi-utilities-bundle/target/maven-status/maven-compiler-plugin/compile/default-compile/inputFiles.lst
xxx/packaging/hudi-utilities-bundle/target/maven-status/maven-compiler-plugin/compile/default-compile/createdFiles.lst
xxx/packaging/hudi-utilities-bundle/target/maven-archiver/pom.properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants