[HUDI-2677] Add DFS based message queue for flink writer #3915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
force-pushed
the
HUDI-2677
branch
4 times, most recently
from
337abdc
to
6890455
Compare
|
Should we give user a configuration for mode selection? |
yuzhaojing
reviewed
Nov 4, 2021
Comment on lines
+54
to
+56
| protected static final int MESSAGE_QUEUE_LENGTH = 20; | ||
|
|
||
| protected static final int CLIENT_MESSAGE_CACHE_SIZE = 10; |
There was a problem hiding this comment.
Should we add these Config in FlinkOptions?
There was a problem hiding this comment.
No, a default config option is enough.
Personally i don't like add options for internal improvements. |
|
+1 LGTM |
danny0405
added a commit
that referenced
this pull request
Nov 4, 2021
danny0405
added a commit
that referenced
this pull request
Nov 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.