[HUDI-3645] fix NPE caused by multiple threads accessing non-thread-safe HashMap #5028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
added
the
priority:major
|
can we file a jira please |
fengjian428
changed the title
|
nsivabalan
added
priority:critical
vingov
pushed a commit
to vingov/hudi
that referenced
this pull request
Apr 3, 2022
…afe HashMap (apache#5028) - Change HashMap in HoodieROTablePathFilter to ConcurrentHashMap
stayrascal
pushed a commit
to stayrascal/hudi
that referenced
this pull request
Apr 12, 2022
…afe HashMap (apache#5028) - Change HashMap in HoodieROTablePathFilter to ConcurrentHashMap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
When users use presto to query hudi tables. I found a NullPointerException seems caused by multiple threads accessing non-thread-safe HashMap. after changed to ConcurrentHashmap this error doesn't happen again
Brief change log
In HoodieROTablePathFilter change hoodiePathCache's type from Hashmap to ConcurrentHashmap
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.