-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-3598] Row Data to Hoodie Record Operator parallelism needs to always be consistent with input operator for chaining purpose #5049
Conversation
@wangxianghu |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why this param is needed ? Generally we avoid introducing too many options if it is not necessary.
The default parallelism would make the map operator chain with source if the souce also has default parallelism.
@danny0405 |
1 similar comment
@danny0405 |
The more proper way is using the source/input parallelism so that the options can be avoided. |
Thanks @JerryYue-M, I am ok with the change. |
This could be a better way, avoid introducing new options. |
@danny0405 @wangxianghu |
…lways be consistent with input operator for chaining purpose
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
@hudi-bot run azure |
@JerryYue-M could you rebase this PR on the latest master? The CI failure is due to clustering failure which has been fixed on the latest master. Once CI passes, the PR is ready for merging. |
@yihua I would just merge it because this change is trivial. |
…lways be consistent with input operator (apache#5049) for chaining purpose Co-authored-by: jerryyue <[email protected]>
…lways be consistent with input operator (apache#5049) for chaining purpose Co-authored-by: jerryyue <[email protected]>
…o adjust the number of parallelism
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.