[HUDI-3652] Make ObjectSizeCalculator threadlocal to reduce memory footprint #5060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sekaiga please format the description appropriately |
| @@ -92,6 +92,7 @@ public static long getObjectSize(Object obj) throws UnsupportedOperationExceptio | |||
| private final Set<Object> alreadyVisited = Collections.newSetFromMap(new IdentityHashMap<>()); | |||
| private final Deque<Object> pending = new ArrayDeque<>(64); | |||
| private long size; | |||
| private static final ThreadLocal<ObjectSizeCalculator> objectSizeCalculator = ThreadLocal.withInitial(() -> new ObjectSizeCalculator(CurrentLayout.SPEC)); | |||
There was a problem hiding this comment.
Let's bubble this up to the top of the declarations list (where all the static members are)
danny0405
changed the title
sekaiga
force-pushed
the
feature/threadlocal_ObjectSizeCalculator2
branch
from
2ca6120
to
0528eca
Compare
|
@hudi-bot run azure |
1 similar comment
|
@hudi-bot run azure |
|
@hudi-bot run azure |
|
@sekaiga can you please rebase master ? this is a small fix we can land for 0.11 |
hudi-common/src/main/java/org/apache/hudi/common/util/ObjectSizeCalculator.java
Outdated
Show resolved
Hide resolved
nsivabalan
added
the
priority:critical
sekaiga
force-pushed
the
feature/threadlocal_ObjectSizeCalculator2
branch
from
0528eca
to
b4f8265
Compare
sekaiga
force-pushed
the
feature/threadlocal_ObjectSizeCalculator2
branch
from
b4f8265
to
421abaa
Compare
|
All checks have passed , please merge , thanks |
CI report:Bot commands@hudi-bot supports the following commands:
|
xushiyan
approved these changes
Apr 14, 2022
xushiyan
pushed a commit
that referenced
this pull request
Apr 14, 2022
…otprint (#5060) Co-authored-by: zhouhuidong <[email protected]>
|
hey @sekaiga this patch seems to break in CI environment. https://dev.azure.com/apache-hudi-ci-org/apache-hudi-ci/_build/results?buildId=8070&view=results |
xushiyan
added a commit
that referenced
this pull request
Apr 14, 2022
xushiyan
added a commit
that referenced
this pull request
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tips
What is the purpose of the pull request
(For example: This pull request adds quick-start document.)
Brief change log
(for example:)
Verify this pull request
(Please pick either of the following options)
This pull request is a trivial rework / code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.