[HUDI-3799] Fixing not deleting empty instants w/o archiving #5261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
force-pushed
the
fixArchivalEmptyInstants
branch
from
a66b342
to
19950a8
Compare
yihua
reviewed
Apr 11, 2022
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/HoodieTimelineArchiver.java
Outdated
Show resolved
Hide resolved
...t/hudi-client-common/src/main/java/org/apache/hudi/client/utils/MetadataConversionUtils.java
Show resolved
Hide resolved
hudi-common/src/test/java/org/apache/hudi/common/testutils/HoodieTestTable.java
Outdated
Show resolved
Hide resolved
|
@yihua : have addressed your comments and fixed test failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of the pull request
In Local and hdfs file schemes, there could be partial files created, where in the commit meta files could be empty. We put in a fix sometime back to delete these entries during archival as it will hinder the archival and will fail the pipeline. But we wanted to maintain the entry for book keeping purposes. So, in this patch, we are not deleting such instances, but creating an instant w/o any plan and serializing it to archived folder. So, that we will know exactly what all entries have been archived.
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
Committer checklist
Has a corresponding JIRA in PR title & commit
Commit message is descriptive of the change
CI is green
Necessary doc changes done or have another open PR
For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.