[HUDI-5078] Fixing determination of table service for metadata calls #7037
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nsivabalan
added
the
priority:major
nsivabalan
changed the title
xushiyan
reviewed
Nov 4, 2022
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/HoodieTable.java
Outdated
Show resolved
Hide resolved
...client/hudi-client-common/src/main/java/org/apache/hudi/table/action/BaseActionExecutor.java
Outdated
Show resolved
Hide resolved
...di-client-common/src/main/java/org/apache/hudi/metadata/HoodieBackedTableMetadataWriter.java
Outdated
Show resolved
Hide resolved
nsivabalan
force-pushed
the
isTableServiceReplaceCommit
branch
from
b2d84de
to
40a2546
Compare
|
@xushiyan : feel free to take another look. |
nsivabalan
force-pushed
the
isTableServiceReplaceCommit
branch
from
40a2546
to
6b24d08
Compare
codope
force-pushed
the
isTableServiceReplaceCommit
branch
from
6b24d08
to
2ce44c5
Compare
danny0405
reviewed
Nov 30, 2022
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/client/BaseHoodieWriteClient.java
Show resolved
Hide resolved
danny0405
requested changes
Nov 30, 2022
codope
added
priority:critical
nsivabalan
force-pushed
the
isTableServiceReplaceCommit
branch
from
2ce44c5
to
c3cf14a
Compare
|
@danny0405 : So, have kept it just for that use-case. have removed elsehwere. |
|
@xushiyan @danny0405 : addressed all reviews |
xushiyan
approved these changes
Dec 9, 2022
hudi-common/src/main/java/org/apache/hudi/common/table/timeline/HoodieInstant.java
Show resolved
Hide resolved
nsivabalan
force-pushed
the
isTableServiceReplaceCommit
branch
from
c3cf14a
to
afb7e32
Compare
nsivabalan
added a commit
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
that referenced
this pull request
Dec 14, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
While applying commit metadata to metadata table, there is an argument "isTableService" to determine whether the triggering action is a table service or not. We mistakenly considered any replace commit as table service. Right fix is, only clustering is table service and other replace commits are not.
Impact
Metadata compaction will make progress with replace commit actions like INSERT_OVERRIDE after this patch.
Risk level (write none, low medium or high below)
low.
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
N/A
Contributor's checklist