-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HUDI-5151] Fix bug with broken flink data skipping caused by ClassNotFoundException of InLineFileSystem #7124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@nsivabalan Could you please take a look at this fix |
trushev
changed the title
[HUDI-5151] Flink data skipping doesn't work with ClassNotFoundException of InLineFileSystem
[HUDI-5151] Fix bug with broken flink data skipping caused by ClassNotFoundException of InLineFileSystem
Nov 3, 2022
…tFoundException of InLineFileSystem
…tFoundException of InLineFileSystem
nsivabalan
added
priority:critical
production down; pipelines stalled; Need help asap.
metadata
metadata table
labels
Nov 7, 2022
danny0405
approved these changes
Nov 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, nice catch ~
Pls merge this fix |
satishkotha
pushed a commit
that referenced
this pull request
Dec 13, 2022
…tFoundException of InLineFileSystem (#7124)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…tFoundException of InLineFileSystem (apache#7124)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…tFoundException of InLineFileSystem (apache#7124)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…tFoundException of InLineFileSystem (apache#7124)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…tFoundException of InLineFileSystem (apache#7124)
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
…tFoundException of InLineFileSystem (apache#7124)
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
…tFoundException of InLineFileSystem (apache#7124)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Pls follow the ticket for more details
This problem has already been fixed by #5194. But the patch doesn't fix flink's issue
We should use
InLineFileSystem.class.getClassLoader()
instead ofThread.currentThread().getContextClassLoader()
because methodlookupRecords(keys, fullKey)
is called fromcommonForkJoinPool-worker
thread which may contain the wrong contextClassLoaderImpact
Fixed flink data skipping issue
Risk level medium
Flink's ut and it
Documentation Update
No need
Contributor's checklist