Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HUDI-5285] Exclude *-site.xml files from jar packaging #7310

Merged
merged 1 commit into from
Nov 29, 2022

Conversation

codope
Copy link
Member

@codope codope commented Nov 28, 2022

Change Logs

Exclude *-site.xml files from jar packaging. Fixes #7292

Impact

Minimal impact. Just excluding some test resources.

Risk level (write none, low medium or high below)

low

Documentation Update

Describe any necessary documentation update if there is any new feature, config, or user-facing change

  • The config description must be updated if new configs are added or the default value of the configs are changed
  • Any new feature or user-facing change requires updating the Hudi website. Please create a Jira ticket, attach the
    ticket number here and follow the instruction to make
    changes to the website.

Contributor's checklist

  • Read through contributor's guide
  • Change Logs and Impact were stated clearly
  • Adequate tests were added if applicable
  • CI passed

@codope
Copy link
Member Author

codope commented Nov 28, 2022

@xushiyan Can you please review this patch? I think we can exclude the test resources (especially the properties files that conflict with user-provided resources) from every module.

@codope codope added dependencies Pull requests that update a dependency file on-call-triaged priority:major degraded perf; unable to move forward; potential bugs labels Nov 28, 2022
@xushiyan
Copy link
Member

@xushiyan Can you please review this patch? I think we can exclude the test resources (especially the properties files that conflict with user-provided resources) from every module.

sounds good. make sure test resources are used strictly by test code

@hudi-bot
Copy link

CI report:

Bot commands @hudi-bot supports the following commands:
  • @hudi-bot run azure re-run the last Azure build

@codope
Copy link
Member Author

codope commented Nov 29, 2022

@xushiyan Can you please review this patch? I think we can exclude the test resources (especially the properties files that conflict with user-provided resources) from every module.

sounds good. make sure test resources are used strictly by test code

Sure. Created HUDI-5292 to track.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file on-call-triaged priority:major degraded perf; unable to move forward; potential bugs
Projects
Archived in project
3 participants