[HUDI-5353] Close file readers #7412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danny0405
reviewed
Dec 9, 2022
| try (HoodieFileReader<GenericRecord> bootstrapReader = | ||
| HoodieFileReaderFactory.getFileReader(bootstrapFileConfig, bootstrapFilePath)) { | ||
| return new MergingIterator<>(recordIterator, bootstrapReader.getRecordIterator(), | ||
| (inputRecordPair) -> HoodieAvroUtils.stitchRecords(inputRecordPair.getLeft(), inputRecordPair.getRight(), mergeHandle.getWriterSchemaWithMetaFields())); |
There was a problem hiding this comment.
Is the record iterator still valid if we close the reader already ?
There was a problem hiding this comment.
Good point! We should pull up the reader. I'll check other such places. Thanks.
danny0405
reviewed
Dec 9, 2022
| try { | ||
| return HoodieFileReaderFactory.getFileReader(table.getHadoopConf(), new Path(clusteringOp.getDataFilePath())).getRecordIterator(readerSchema); | ||
| try (HoodieFileReader fileReader = HoodieFileReaderFactory.getFileReader(table.getHadoopConf(), new Path(clusteringOp.getDataFilePath()))) { | ||
| return fileReader.getRecordIterator(readerSchema); |
nsivabalan
approved these changes
Dec 10, 2022
| * @param conf Configuration | ||
| * @return | ||
| */ | ||
| public static Schema getBaseFileSchema(FileSplit split, Configuration conf) { |
There was a problem hiding this comment.
there are no usages for these is it ?
codope
force-pushed
the
mt-validator-close-rader
branch
from
674fcb3
to
bf7a262
Compare
|
CI is green after retry. There is a flaky test unrelated to this PR and it's being tracked in https://issues.apache.org/jira/browse/HUDI-5371 |
nsivabalan
pushed a commit
that referenced
this pull request
Dec 13, 2022
nsivabalan
pushed a commit
that referenced
this pull request
Dec 13, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
to onehouseinc/hudi
that referenced
this pull request
Dec 14, 2022
alexeykudinkin
pushed a commit
that referenced
this pull request
Dec 14, 2022
fengjian428
pushed a commit
to fengjian428/hudi
that referenced
this pull request
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Logs
Close file readers wherever missing.
Impact
Simply closes file reader. Better use of connection pool.
Risk level (write none, low medium or high below)
low
Documentation Update
Describe any necessary documentation update if there is any new feature, config, or user-facing change
ticket number here and follow the instruction to make
changes to the website.
Contributor's checklist