Remove deprecated datetime functions
#1134
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinjqliu
approved these changes
Sep 5, 2024
| @@ -3915,7 +3915,7 @@ def snapshots(self) -> "pa.Table": | |||
| additional_properties = None | |||
|
|
|||
| snapshots.append({ | |||
| "committed_at": datetime.utcfromtimestamp(snapshot.timestamp_ms / 1000.0), | |||
| "committed_at": datetime.fromtimestamp(snapshot.timestamp_ms / 1000.0, tz=timezone.utc), | |||
There was a problem hiding this comment.
| @@ -615,8 +615,6 @@ filterwarnings = [ | |||
| "ignore:unclosed <socket.socket", | |||
| # Remove this in a future release of PySpark. | |||
| "ignore:distutils Version classes are deprecated. Use packaging.version instead.", | |||
| "ignore:datetime.datetime.utcnow\\(\\) is deprecated and scheduled for removal in a future version.", | |||
There was a problem hiding this comment.
huh, not sure where this went, theres no references in the codebase
https://github.com/search?q=repo%3Aapache%2Ficeberg-python%20utcnow&type=code
There was a problem hiding this comment.
it might be used in one of the dependency packages, but we don't need to filter the warning in that case
Fokko
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Thanks for cleaning this up @hussein-awala Could you resolve the conflicts? Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #1133