Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace numpy usage and remove from pyproject.toml #1272

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

kevinjqliu
Copy link
Contributor

Follow up to #1270
Replace all other references of numpy and remove numpy from pyproject.toml.

The current reference of numpy in poetry.lock is coming from pandas. From poetry show --tree,

pandas 2.0.3 Powerful data structures for data analysis, time series, and statistics
├── numpy >=1.20.3
├── numpy >=1.23.2
├── numpy >=1.21.0
├── python-dateutil >=2.8.2
│   └── six >=1.5 
├── pytz >=2020.1
└── tzdata >=2022.1

@kevinjqliu kevinjqliu requested a review from Fokko October 30, 2024 21:12
@kevinjqliu kevinjqliu added this to the PyIceberg 0.8.0 release milestone Oct 30, 2024
Copy link
Contributor

@Fokko Fokko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Even better, thanks @kevinjqliu

@Fokko Fokko merged commit 0cebec4 into apache:main Oct 31, 2024
7 checks passed
@kevinjqliu kevinjqliu deleted the kevinjqliu/remove-numpy branch October 31, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants