Glue: Allow for assuming role for Glue #1299
Conversation
| ) | ||
| refreshable_credentials = DeferredRefreshableCredentials( | ||
| method="assume-role", | ||
| refresh_using=fetcher.fetch_credentials, |
There was a problem hiding this comment.
I'm relying on calling an in-house webservice that will provide new credentials. As I see it, this implementation will not allow a custom implementation of refresh_using that would enable me to call the webservice.
| ) | ||
| from botocore.session import Session as BotoSession | ||
|
|
||
| botocore_session = BotoSession() |
There was a problem hiding this comment.
How about accepting a boto3.Session as input? Then the client can configure it as needed.
There was a problem hiding this comment.
First of all, thanks @cshenrik for the quick reply!
I think we could do both, so you can also configure the Glue client similar to the S3 one (it uses similar properties).
@HonahX @kevinjqliu How strong are we on only passing str's? Otherwise, I think we might start jumping through hoops to get it working (eg. do something similar as when loading a custom FileIO).
Fixes #1104
PTAL @BTheunissen @cshenrik