Add entries metadata table #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fokko
commented
Mar 27, 2024
tests/integration/test_writes.py
Outdated
|
|
||
|
|
||
| @pytest.mark.integration | ||
| @pytest.mark.parametrize("format_version", [1, 2]) |
There was a problem hiding this comment.
Moved the metadata tables to their own tests file to avoid blowing up this one :)
|
This will also make it easier to check the sequence numbers for #363 |
HonahX
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Overall LGTM! @Fokko Thanks for the effort! Just one comment: Shall we add a section here https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/api.md#inspecting-tables to provide an example of
table.inspect.entries()
|
Good one @HonahX, just added it 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.