-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Files metadata table #614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Gowthami03B this looks great. I have one request to add the optional snapshot_id argument to support time traveling between different snapshots Iceberg metadata table.
Hi @HonahX could we get your help in triggering this workflow to see if the CI succeeds? |
merge main into feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hello @HonahX
Can I get a re-trigger again (the checks succeeds in my PR to my fork, so I am confident)?
Also requesting re-review here , I addressed the comments, hoping we could close this :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for adding this @Gowthami03B.
merge main into feature
42d091d
to
334cf94
Compare
Sorry for now following up on this @Gowthami03B Could you rebase so we can get this in? Thanks! |
@Gowthami03B gentle ping, this is the last metadata table, and we would love to include this into the release! 🙌 |
@Fokko @kevinjqliu @amogh-jahagirdar Can I get a re-review here please? Want to close this asap for the release timeline :) |
Merge main into feature
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too. @Gowthami03B Thanks for working on this! Thanks everyone for reviewing. Let's get this last metadata table in! |
Hi guys, sorry if it's not the right place to ask this question. I haven't profiled yet but I guess the gist of the issue is As of now pyspark's |
I think there's definitely room for improvement. @DieHertz do you mind opening an issue for this? |
Will do |
No description provided.