Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow empty names in mapped field of Name Mapping #927

Merged
merged 5 commits into from
Jul 14, 2024
Merged

Allow empty names in mapped field of Name Mapping #927

merged 5 commits into from
Jul 14, 2024

Commits on Jul 13, 2024

  1. Remove check_at_least_one field validator 

    Iceberg spec permits an emtpy list of names in the default name mapping. check_at_least_one is therefore unnecessary.
    @spock-abadai
    spock-abadai committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    c9bfa27 View commit details
    Browse the repository at this point in the history

  2. Remove irrelevant test case

    @spock-abadai
    spock-abadai committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    15b05c7 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2024

  1. Fixing pydantic model 

    No longer requiring minimum length of names list to be 1.
    @spock-abadai
    spock-abadai committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    12c3591 View commit details
    Browse the repository at this point in the history

  2. Added test case for empty names in name mapping

    @spock-abadai
    spock-abadai committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    f7ef81c View commit details
    Browse the repository at this point in the history

  3. Fixed formatting error

    @spock-abadai
    spock-abadai committed Jul 14, 2024
    Configuration menu
    Copy the full SHA
    9bea754 View commit details
    Browse the repository at this point in the history