Fix issues related to having catalog_name in identifier #964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HonahX
changed the title
HonahX
commented
Jul 25, 2024
| # specific language governing permissions and limitations | ||
| # under the License. | ||
| # pylint:disable=redefined-outer-name | ||
| from typing import List, Optional, Union |
There was a problem hiding this comment.
This may be moved to test_writes.py Putting it here temporarily.
sungwy
reviewed
Jul 25, 2024
tests/catalog/test_rest.py
Outdated
| @@ -1226,3 +1226,25 @@ def test_catalog_from_parameters_empty_env(rest_mock: Mocker) -> None: | |||
|
|
|||
| catalog = cast(RestCatalog, load_catalog("production", uri="https://other-service.io/api")) | |||
| assert catalog.uri == "https://other-service.io/api" | |||
|
|
|||
|
|
|||
| def test_commit_table_fail(rest_mock: Mocker, example_table_metadata_v2: Dict[str, Any]) -> None: | |||
There was a problem hiding this comment.
nit: I find the name of this test confusing as it sounds like we are expecting the table commit to fail, but it succeeds with a 200 status code within the test
|
+1 to this solution for 0.7.0 @HonahX . This is a creative way to mitigate the issue for the release in the short term. Thank you for taking your time to put together this solution so quickly! |
Fokko
approved these changes
Jul 25, 2024
kevinjqliu
approved these changes
Jul 26, 2024
sungwy
approved these changes
Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt to fix #742 without removing the catalog_name. This may serve as a temporary solution if we finally decide to
do #963 in a later release (or not remove). Otherwise #963 should be preferred